Make the template pass cargo clippy by resolving warnings #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time! 👍 Cool to see that stable clippy lints for this now. |
|
No problem! Any interest in making it pass |
|
I ran it over the code and think most of these lints, especially the documentation / panic related ones, are not too relevant for us and can be ignored. There are some that we could adopt:
I would accept a PR for those, but can also tackle it at some point before december this year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve the
cargo clippywarnings in the template so that new projects created from the template will only show warnings on code added by the user.All of the errors are
clippy::uninlined_format_args